Changeset 02d288d in flexoentity for tests/test_persistance_integrity.py

Timestamp:

10/23/25 13:27:08 (3 months ago)

Author:

Enrico Schwass <ennoausberlin@…>

Branches:

master

Children:

4ceca57

Parents:

6a7dec1

Message:

improve hash generation and collision handler - move signature from FlexOID to FlexoEntity

File:

• tests/test_persistance_integrity.py (modified) (2 diffs)

tests/test_persistance_integrity.py

@@ -6 +6 @@
 import pytest
 
-from flexoentity import FlexOID, EntityType, EntityState
-from tests.conftest import DummyEntity
+from flexoentity import EntityState
+from builder.questions import RadioQuestion, AnswerOption
 
 
 # ──────────────────────────────────────────────────────────────────────────────
 @pytest.fixture
-def approved_entity():
-    """A fully published dummy entity for persistence tests."""
-    e = DummyEntity(
-        domain="AF",
-        etype=EntityType.QUESTION,
+def approved_question(domain):
+    """Provide a fully approved and published RadioQuestion for persistence tests."""
+    q = RadioQuestion(
+        domain=domain,
+        etype=None,  # RadioQuestion sets this internally to EntityType.QUESTION
         state=EntityState.DRAFT,
-        seed="What is Ohm’s law?"
+        text="What is Ohm’s law?",
+        options=[
+            AnswerOption(text="U = R × I", points=1),
+            AnswerOption(text="U = I / R", points=0),
+            AnswerOption(text="R = U × I", points=0),
+        ],
     )
-    e.approve()
-    e.sign()
-    e.publish()
-    return e
+    q.approve()
+    q.sign()
+    q.publish()
+    return q
 
-@pytest.mark.skip(reason="FlexOIDs are regenerated on import; enable once JSON format is stable")
-def test_json_roundtrip_preserves_integrity(approved_entity):
+
+@pytest.mark.skip(reason="FlexOIDs regenerated on import; enable once JSON format is stable")
+def test_json_roundtrip_preserves_integrity(approved_question):
     """
-    Export to JSON and reload — ensure fingerprints remain valid.
+    Export to JSON and reload — ensure fingerprints and signatures remain valid.
     """
-    json_str = approved_entity.to_json()
-    loaded = approved_entity.__class__.from_json(json_str)
+    json_str = approved_question.to_json()
+    loaded = RadioQuestion.from_json(json_str)
 
     # Fingerprint and state should match — integrity must pass
-    assert approved_entity.__class__.verify_integrity(loaded)
+    assert RadioQuestion.verify_integrity(loaded)
 
     # Metadata should be preserved exactly
-    assert approved_entity.flexo_id.signature == loaded.flexo_id.signature
-    assert approved_entity.flexo_id == loaded.flexo_id
-    assert loaded.state == approved_entity.state
+    assert approved_question.signature == loaded.signature
+    assert approved_question.flexo_id == loaded.flexo_id
+    assert loaded.state == approved_question.state
+
 
 # ──────────────────────────────────────────────────────────────────────────────
 
-@pytest.mark.skip(reason="FlexOIDs regenerated on import; tampering detection not applicable yet")
-def test_json_tampering_detection(approved_entity):
+@pytest.mark.skip(reason="FlexOIDs regenerated on import; tampering detection not yet implemented")
+def test_json_tampering_detection(approved_question):
     """Tampering with content should invalidate fingerprint verification."""
-    json_str = approved_entity.to_json()
-    tampered_data = json.loads(json_str)
-    tampered_data["text_seed"] = "Tampered content injection"
-    tampered_json = json.dumps(tampered_data)
+    json_str = approved_question.to_json()
+    tampered = json.loads(json_str)
+    tampered["text"] = "Tampered content injection"
+    tampered_json = json.dumps(tampered)
 
-    # We use DummyEntity.from_json to reconstruct (FlexoEntity is abstract)
-    loaded = approved_entity.__class__.from_json(tampered_json)
-    assert not approved_entity.__class__.verify_integrity(loaded)
+    loaded = RadioQuestion.from_json(tampered_json)
+    assert not RadioQuestion.verify_integrity(loaded)
 
 
@@ -59 +65 @@
 
 @pytest.mark.skip(reason="FlexOIDs regenerated on import; corruption detection not yet applicable")
-def test_json_file_corruption(approved_entity, tmp_path):
+def test_json_file_corruption(approved_question, tmp_path):
     """Simulate file corruption — integrity check must fail."""
-    file = tmp_path / "entity.json"
-    json_str = approved_entity.to_json()
+    file = tmp_path / "question.json"
+    json_str = approved_question.to_json()
     file.write_text(json_str)
 
-    # Corrupt the file
+    # Corrupt the file (simulate accidental byte modification)
     corrupted = json_str.replace("Ohm’s", "Omm’s")
     file.write_text(corrupted)
 
-    loaded = approved_entity.__class__.from_json(file.read_text())
-    assert not approved_entity.__class__.verify_integrity(loaded)
+    loaded = RadioQuestion.from_json(file.read_text())
+    assert not RadioQuestion.verify_integrity(loaded)