Changeset 02d288d in flexoentity for tests/test_id_lifecycle.py

Timestamp:

10/23/25 13:27:08 (3 months ago)

Author:

Enrico Schwass <ennoausberlin@…>

Branches:

master

Children:

4ceca57

Parents:

6a7dec1

Message:

improve hash generation and collision handler - move signature from FlexOID to FlexoEntity

File:

• tests/test_id_lifecycle.py (modified) (1 diff)

tests/test_id_lifecycle.py

@@ -1 +1 @@
 import pytest
-
-from flexoentity import FlexOID, FlexoEntity, EntityType, EntityState 
-
-def test_initial_state(entity):
-    assert entity.state == EntityState.DRAFT
-    assert entity.flexo_id.version == 1
-    assert len(entity.flexo_id.signature) == 16  # blake2s digest_size=8 → 16 hex
-    assert FlexoEntity.verify_integrity(entity)
+from flexoentity import FlexOID, FlexoEntity, EntityType, EntityState
 
 
-def test_approval_bumps_version(entity):
-    entity.approve()
-    assert entity.state == EntityState.APPROVED
-    assert entity.flexo_id.version == 2
+# ──────────────────────────────────────────────────────────────────────────────
+# Tests adapted to use real RadioQuestion fixture instead of DummyEntity
+# ──────────────────────────────────────────────────────────────────────────────
+
+def test_initial_state(radio_question):
+    q = radio_question
+    assert q.state == EntityState.DRAFT
+    assert q.flexo_id.version == 1
+    assert FlexoEntity.verify_integrity(q)
 
 
-def test_signing_bumps_version(entity):
-    entity.approve()
-    v_before = entity.flexo_id
-    entity.sign()
-    assert entity.state == EntityState.APPROVED_AND_SIGNED
-    assert entity.flexo_id != v_before
+def test_approval_bumps_version(radio_question):
+    q = radio_question
+    q.approve()
+    assert q.state == EntityState.APPROVED
+    assert q.flexo_id.version == 2
 
 
-def test_publish_bumps_version(entity):
-    entity.approve()
-    entity.sign()
-    v_before = entity.flexo_id.version
-    entity.publish()
-    assert entity.state == EntityState.PUBLISHED
-    assert entity.flexo_id.version == v_before + 1
+def test_signing_bumps_version(radio_question):
+    q = radio_question
+    q.approve()
+    v_before = str(q.flexo_id)
+    q.sign()
+    assert q.state == EntityState.APPROVED_AND_SIGNED
+    assert str(q.flexo_id) != v_before
 
 
-def test_modify_content_changes_fingerprint(entity):
-    old_signature = entity.flexo_id.signature
-    entity._seed = "Rephrased content"  # simulate text change
-    entity._update_fingerprint()
-    assert entity.flexo_id.signature != old_signature
+def test_publish_bumps_version(radio_question):
+    q = radio_question
+    q.approve()
+    q.sign()
+    v_before = q.flexo_id.version
+    q.publish()
+    assert q.state == EntityState.PUBLISHED
+    assert q.flexo_id.version == v_before + 1
 
 
-def test_no_version_bump_on_draft_edits(entity):
-    entity._seed = "Draft edit only"
-    entity._update_fingerprint()
-    assert entity.flexo_id.version == 1
+def test_modify_content_changes_fingerprint(radio_question):
+    q = radio_question
+    q.text = "Rephrased content"  # simulate text change
+    changed = q._update_fingerprint()
+    assert changed
 
 
-def test_version_bump_after_edit_and_sign(entity):
-    entity.approve()
-    v1 = entity.flexo_id
-    entity._seed = "Changed content"
-    entity.sign()
-    assert entity.flexo_id != v1
+def test_no_version_bump_on_draft_edits(radio_question):
+    q = radio_question
+    q.text = "Minor draft edit"
+    q._update_fingerprint()
+    assert q.flexo_id.version == 1
 
 
-def test_integrity_check_passes_and_fails(entity):
-    entity.approve()
-    assert FlexoEntity.verify_integrity(entity)
-    # simulate tampering
-    entity._seed = "Tampered text"
-    assert not FlexoEntity.verify_integrity(entity)
+def test_version_bump_after_edit_and_sign(radio_question):
+    q = radio_question
+    q.approve()
+    v1 = str(q.flexo_id)
+    q.text = "Changed content"
+    q.sign()
+    assert str(q.flexo_id) != v1
 
 
-def test_obsolete_state(entity):
-    entity.approve()
-    entity.sign()
-    entity.publish()
-    entity.obsolete()
-    assert entity.state == EntityState.OBSOLETE
+def test_integrity_check_passes_and_fails(radio_question):
+    q = radio_question
+    q.approve()
+    assert FlexoEntity.verify_integrity(q)
+
+    # simulate tampering
+    q.text = "Tampered text"
+    assert not FlexoEntity.verify_integrity(q)
 
 
-def test_clone_new_base_resets_lineage(entity):
-    entity.approve()
-    entity.sign()
-    entity.publish()
-    entity.obsolete()
-    old_id = entity.flexo_id
-    entity.clone_new_base()
-    assert entity.flexo_id != old_id
-    assert entity.state == EntityState.DRAFT
-    assert entity.flexo_id.version == 1
+def test_obsolete_state(radio_question):
+    q = radio_question
+    q.approve()
+    q.sign()
+    q.publish()
+    q.obsolete()
+    assert q.state == EntityState.OBSOLETE
 
 
-def test_mass_version_increments_until_obsolete(entity):
-    entity.approve()
+def test_clone_new_base_resets_lineage(radio_question):
+    q = radio_question
+    q.approve()
+    q.sign()
+    q.publish()
+    q.obsolete()
+    old_id = str(q.flexo_id)
+    q.clone_new_base()
+    assert str(q.flexo_id) != old_id
+    assert q.state == EntityState.DRAFT
+    assert q.flexo_id.version == 1
+
+
+def test_mass_version_increments_until_obsolete(radio_question):
+    q = radio_question
+    q.approve()
     for _ in range(FlexOID.MAX_VERSION - 2):
-        entity.sign()
+        q.sign()
     with pytest.raises(RuntimeError, match="mark obsolete"):
-        entity.sign()
+        q.sign()