Changeset 5c72356 in flexoentity for tests

Timestamp:

11/02/25 18:49:14 (2 months ago)

Author:

Enrico Schwass <ennoausberlin@…>

Branches:

master

Children:

bf30018

Parents:

8aa20c7

Message:

fix tests due to simplifying state and type

Location:

tests

Files:

• conftest.py (modified) (5 diffs)
• test_id_lifecycle.py (modified) (4 diffs)
• test_id_stress.py (modified) (1 diff)

tests/conftest.py

@@ -4 +4 @@
 from dataclasses import dataclass, field
 from typing import List
-from flexoentity import FlexoEntity, EntityType, EntityState, Domain
+from flexoentity import FlexOID, FlexoEntity, EntityType, EntityState, Domain
 
 @pytest.fixture
@@ -37 +37 @@
 class SingleChoiceQuestion(FlexoEntity):
     """A minimal stub to test FlexoEntity integration."""
+    ENTITY_TYPE = EntityType.ITEM
+
     text: str = ""
     options: List[AnswerOption] = field(default_factory=list)
 
+    def __post_init__(self):
+        # If no FlexOID yet, generate a draft ID now.
+        if not getattr(self, "flexo_id", None):
+            domain_code = (
+                self.domain.domain if isinstance(self.domain, Domain) else "GEN"
+            )
+            self.flexo_id = FlexOID.safe_generate(
+                domain=domain_code,
+                entity_type=EntityType.ITEM.value,     # 'I'
+                estate=EntityState.DRAFT.value,        # 'D'
+                text=self.text_seed or self.text,
+                version=1,
+            )
 
     @classmethod
     def default(cls):
-        return cls(domain=Domain(domain="GEN",
-                                 entity_type=EntityType.DOMAIN,
-                                 state=EntityState.DRAFT),
-                   state=EntityState.DRAFT, entity_type=EntityType.ITEM)
+        return cls(domain=Domain(domain="GEN"))
 
     def to_dict(self):
@@ -68 +80 @@
     @classmethod
     def from_dict(cls, data):
-        obj = cls(
+        obj = cls(domain=Domain(domain="GEN"),
             text=data.get("text", ""),
             options=[AnswerOption.from_dict(o) for o in data.get("options", [])],
@@ -74 +86 @@
         # restore FlexoEntity core fields
         obj.domain = data.get("domain")
-        obj.entity_type = EntityType[data.get("etype")] if "etype" in data else EntityType.ITEM
-        obj.state = EntityState[data.get("state")] if "state" in data else EntityState.DRAFT
         if "flexo_id" in data:
-            from flexoentity import FlexOID
             obj.flexo_id = FlexOID.parsed(data["flexo_id"])
         return obj
@@ -87 +96 @@
 @pytest.fixture
 def sample_question():
-    return SingleChoiceQuestion(domain=Domain.default(),
-                               text="What is 2 + 2?",
-                               options=[],
-                               entity_type=EntityType.ITEM,
-                               state=EntityState.DRAFT)
+    q = SingleChoiceQuestion(domain=Domain.default(),
+                             text="What is 2 + 2?",
+                             options=[])
+    q._update_fingerprint()
+    return q

tests/test_id_lifecycle.py

@@ -20 +20 @@
     assert q.flexo_id.version == 1
 
-
-def test_signing_bumps_version(sample_question):
+def test_signing_does_not_bump_version(sample_question):
     q = sample_question
     q.approve()
-    v_before = str(q.flexo_id)
+    before = q.flexo_id
     q.sign()
+    after = q.flexo_id
+
+    # state changed
     assert q.state == EntityState.APPROVED_AND_SIGNED
-    assert str(q.flexo_id) != v_before
+
+    # version unchanged
+    assert before.version == after.version
+
+    # only suffix letter differs
+    assert before.prefix == after.prefix
+    assert before.state_code == "A"
+    assert after.state_code == "S"
 
 
-def test_publish_bumps_version(sample_question):
+def test_publish_does_not_bump_version(sample_question):
     q = sample_question
     q.approve()
@@ -37 +46 @@
     q.publish()
     assert q.state == EntityState.PUBLISHED
-    assert q.flexo_id.version == v_before + 1
+    assert q.flexo_id.version == v_before
 
 
@@ -70 +79 @@
     # simulate tampering
     q.text = "Tampered text"
+    print(FlexoEntity.debug_integrity(q))
     assert not FlexoEntity.verify_integrity(q)
 
@@ -112 +122 @@
     for _ in range(FlexOID.MAX_VERSION - 1):
         q.bump_version()
+
+    # Next one must raise
     with pytest.raises(RuntimeError, match="mark obsolete"):
-        q.sign()
+        q.bump_version()

tests/test_id_stress.py

@@ -82 +82 @@
 
 
-def test_version_ceiling_enforcement(sample_question):
-    """Simulate approaching @999 to trigger obsolescence guard."""
-    q = sample_question
-    q.approve()
-
-    # artificially bump version number to near ceiling
-    q.flexo_id = FlexOID.from_oid_and_version(q.flexo_id, 998)
-
-    # 998 → 999 is allowed
-    q.sign()
-    assert q.flexo_id.version == 999
-
-    # 999 → 1000 should raise RuntimeError
-    with pytest.raises(ValueError):
-        q.publish()
-
-
 def test_massive_lifecycle_simulation(sample_question):
     """